Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion goldens/Basic_cluster_create.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ kubectl wait deploy/kueue-controller-manager -nkueue-system --for=condition=avai
[XPK] Install Kueue Custom Resources
[XPK] Try 1: Applying Kueue Custom Resources
[XPK] Task: `Applying Kueue Custom Resources` is implemented by the following command not running since it is a dry run.
kubectl apply -f 0f9af4fcbf6d012aed0c8e09d49827dc34495d3eed2893af6b68b2d121a519ac
kubectl apply -f c49da377b542c14a80a64a13236f8d3a1c8e022dc7c82cc6f6f0560d980ee9e7
[XPK] Update Kueue Controller Manager resources
[XPK] Task: `Count total nodes` is implemented by the following command not running since it is a dry run.
kubectl get node --no-headers | wc -l
Expand Down
2 changes: 1 addition & 1 deletion goldens/Cluster_create_private.txt
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ kubectl wait deploy/kueue-controller-manager -nkueue-system --for=condition=avai
[XPK] Install Kueue Custom Resources
[XPK] Try 1: Applying Kueue Custom Resources
[XPK] Task: `Applying Kueue Custom Resources` is implemented by the following command not running since it is a dry run.
kubectl apply -f e528cf13756aaba6ef43789e09518fb9bcc6d43a945b51fb76d16e9869c73eec
kubectl apply -f ec56970df5766f33e470374e087b3061d9960c171fce12fdb2d75170eb75fe55
[XPK] Update Kueue Controller Manager resources
[XPK] Task: `Count total nodes` is implemented by the following command not running since it is a dry run.
kubectl get node --no-headers | wc -l
Expand Down
2 changes: 1 addition & 1 deletion goldens/NAP_cluster-create.txt
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ kubectl wait deploy/kueue-controller-manager -nkueue-system --for=condition=avai
[XPK] Install Kueue Custom Resources
[XPK] Try 1: Applying Kueue Custom Resources
[XPK] Task: `Applying Kueue Custom Resources` is implemented by the following command not running since it is a dry run.
kubectl apply -f b3843453fb19ae7105126245bac5b63930f46861462cd3a557aea44801a99280
kubectl apply -f eaa77bda2c85901c627ae9bb4baacdb37df006d6bf267b319b6bc8b2cbf7ca7e
[XPK] Update Kueue Controller Manager resources
[XPK] Task: `Count total nodes` is implemented by the following command not running since it is a dry run.
kubectl get node --no-headers | wc -l
Expand Down
2 changes: 1 addition & 1 deletion goldens/NAP_cluster-create_with_pathways.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ kubectl wait deploy/kueue-controller-manager -nkueue-system --for=condition=avai
[XPK] Install Kueue Custom Resources
[XPK] Try 1: Applying Kueue Custom Resources
[XPK] Task: `Applying Kueue Custom Resources` is implemented by the following command not running since it is a dry run.
kubectl apply -f 898c7686cc5ef7f026f74e55b73b5843767e3f1abb9639169f02ebc44d06af73
kubectl apply -f 7ffd24a656c1ec9c1d331862e352cefd5348637b0f776a8e3db888b04fa7fad6
[XPK] Update Kueue Controller Manager resources
[XPK] Task: `Count total nodes` is implemented by the following command not running since it is a dry run.
kubectl get node --no-headers | wc -l
Expand Down
1 change: 0 additions & 1 deletion src/xpk/core/kueue.py
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@ def install_kueue_crs(
]:
yml_string = topology_yaml + yml_string

print(yml_string)
tmp = write_tmp_file(yml_string)
command = f'kubectl apply -f {str(tmp)}'

Expand Down
19 changes: 18 additions & 1 deletion src/xpk/parser/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,14 +174,15 @@ def set_cluster_create_parser(cluster_create_parser: ArgumentParser):
'Arguments for configuring MTC in cluster create.',
)
add_shared_cluster_create_mtc_arguments(cluster_create_mtc_arguments)
cluster_create_parser.set_defaults(func=cluster_create)

cluster_create_resource_limits = cluster_create_parser.add_argument_group(
'Optional Resource Limits Arguments',
'Arguments for configuring resource limits in cluster create.',
)
add_resource_limits(cluster_create_resource_limits)

cluster_create_parser.set_defaults(func=cluster_create)


def set_cluster_create_pathways_parser(
cluster_create_pathways_parser: ArgumentParser,
Expand Down Expand Up @@ -251,6 +252,15 @@ def set_cluster_create_pathways_parser(
)
)
add_shared_cluster_create_mtc_arguments(cluster_create_mtc_arguments)

cluster_create_resource_limits = (
cluster_create_pathways_parser.add_argument_group(
'Optional Resource Limits Arguments',
'Arguments for configuring resource limits in cluster create.',
)
)
add_resource_limits(cluster_create_resource_limits)

cluster_create_pathways_parser.set_defaults(func=cluster_create_pathways)


Expand Down Expand Up @@ -326,6 +336,13 @@ def set_cluster_create_ray_parser(cluster_create_ray_parser: ArgumentParser):
'Arguments for configuring MTC in cluster create.',
)
add_shared_cluster_create_mtc_arguments(cluster_create_mtc_arguments)

cluster_create_resource_limits = cluster_create_ray_parser.add_argument_group(
'Optional Resource Limits Arguments',
'Arguments for configuring resource limits in cluster create.',
)
add_resource_limits(cluster_create_resource_limits)

cluster_create_ray_parser.set_defaults(func=cluster_create_ray_cluster)


Expand Down
Loading