Skip to content

Use map NodeSelector instead of string for Pathways workload #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Use map NodeSelector instead of string for Pathways workload #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion goldens/Workload_create_pathways.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ docker tag dry-run-runner gcr.io/golden-project/dry-run-runner:prefix-current
[XPK] Task: `Upload Docker Image` is implemented by the following command not running since it is a dry run.
docker push gcr.io/golden-project/dry-run-runner:prefix-current
[XPK] Task: `Creating Workload` is implemented by the following command not running since it is a dry run.
kubectl apply -f bfdb43fce214301b0be1d293cb623b61df6e14c376a0032cdc3273ed14f5a6f7
kubectl apply -f 574963d6d441695d681ff94ad241e713559f64b4ce519f4f1e0708c659f1c25d
[XPK] Task: `GKE Dashboard List` is implemented by the following command not running since it is a dry run.
gcloud monitoring dashboards list --project=golden-project --filter="displayName:'GKE - TPU Monitoring Dashboard'" --format="value(name)" --verbosity=error
[XPK] Check statistics and outlier mode of GKE metrics here: https://console.cloud.google.com/monitoring/dashboards/builder/0?project=golden-project&f.rlabel.cluster_name.ClusterName=golden-cluster. To view the metric data for your workload, select golden-workload from the JobName filter on the dashboard.
Expand Down
5 changes: 3 additions & 2 deletions src/xpk/commands/workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,8 @@
maxSliceRestarts: {args.max_slice_restarts}
terminationGracePeriodSeconds: {args.termination_grace_period_seconds}
priorityClassName: {args.priority}
capacityNodeSelector: {capacity_node_selector}
nodeSelector:
{autoprovisioning_args}
pathwaysDir: {args.pathways_gcs_location} #This bucket needs to be created in advance.
controller:
# #Pod template for training, default mode.
Expand Down Expand Up @@ -546,7 +547,7 @@ def workload_create(args) -> None:
colocated_python_sidecar=append_custom_colocated_python_sidecar(args),
user_workload=get_user_workload_for_pathways(args, system),
local_queue_name=LOCAL_QUEUE_NAME,
capacity_node_selector=autoprovisioning_args,
autoprovisioning_args=autoprovisioning_args,
)
else:
container, debugging_dashboard_id = get_user_workload_container(
Expand Down
Loading