Use shorter names in nightly tests #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamOne-
requested changes
Oct 10, 2025
Collaborator
jamOne-
left a comment
jamOne-
left a comment
There was a problem hiding this comment.
These logs don't contain any credentials, right?
jamOne-
reviewed
Oct 10, 2025
Collaborator
Author
They contain only error messages returned by gcloud, I highly doubt that will print any credentials |
jamOne-
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix private cluster integration test by using shorter names.
Currently private cluster test always fails with:
ERROR: (gcloud.beta.container.node-pools.create) ResponseError: code=400, message=Node_pool.name must be less than 40 characters.
Some other changes include, uploading an artifact with the NodePools error log in cluster creating tests to improve debugging