Skip to content

Shell commands granular dependencies validation #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Shell commands granular dependencies validation #702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b079877
feat: shell commands granular dependencies validation
scaliby Oct 20, 2025
f91f804
Merge branch 'develop' into scaliby/shell-cmds-granular-deps-validation
scaliby Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/xpk/commands/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from ..core.commands import run_command_with_full_controls, run_command_for_value, run_command_with_updates
from ..core.cluster import get_cluster_credentials, add_zone_and_project, setup_k8s_service_accounts
from ..utils.console import xpk_exit, xpk_print
from ..utils.validation import validate_dependencies, should_validate_dependencies
from ..utils.validation import validate_dependencies_list, SystemDependency, should_validate_dependencies
from argparse import Namespace

from ..core.kjob import (
Expand All @@ -35,7 +35,11 @@ def shell(args: Namespace):
0 if successful and 1 otherwise.
"""
if should_validate_dependencies(args):
validate_dependencies()
validate_dependencies_list([
SystemDependency.KUBECTL,
SystemDependency.KJOB,
SystemDependency.GCLOUD,
])
exisitng_shell_pod_name = get_existing_shell_pod_name(args)

if exisitng_shell_pod_name is None:
Expand Down Expand Up @@ -118,7 +122,9 @@ def shell_stop(args: Namespace):
0 if successful and 1 otherwise.
"""
if should_validate_dependencies(args):
validate_dependencies()
validate_dependencies_list(
[SystemDependency.KUBECTL, SystemDependency.GCLOUD]
)
exisitng_shell_pod_name = get_existing_shell_pod_name(args)

if exisitng_shell_pod_name is None:
Expand Down
Loading