Skip to content

Fix admission_checks test case in kueue_manager_test #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Fix admission_checks test case in kueue_manager_test #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 3 additions & 34 deletions src/xpk/core/kueue_manager_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,10 +423,10 @@ def test_configure_generates_correct_manifest(
@patch(
"xpk.core.kueue_manager.KueueManager._KueueManager__update_kueue_resources_if_necessary"
)
def test_configure_generates_correct_manifest_with_admission_checks(
def test_configure_generates_manifest_with_admission_checks_for_flex_single_slice(
self, mock_update_resources, mock_install, mock_apply_manifest
):
"""Test that __configure generates the correct manifest content for TPUs."""
"""Test that __configure generates the correct manifest with admission checks."""
mock_install.return_value = 0
mock_update_resources.return_value = 0
mock_apply_manifest.return_value = 0
Expand Down Expand Up @@ -465,38 +465,7 @@ def test_configure_generates_correct_manifest_with_admission_checks(
cluster_queue["spec"]["resourceGroups"][0]["flavors"][0]["name"],
"1xv5p-8",
)
resources = cluster_queue["spec"]["resourceGroups"][0]["flavors"][0][
"resources"
]
tpu_resource = next(
(r for r in resources if r["name"] == "google.com/tpu"), None
)
cpu_resource = next((r for r in resources if r["name"] == "cpu"), None)
memory_resource = next(
(r for r in resources if r["name"] == "memory"), None
)
self.assertIsNotNone(tpu_resource)
self.assertEqual(tpu_resource["nominalQuota"], 8)
self.assertIsNotNone(cpu_resource)
self.assertEqual(cpu_resource["nominalQuota"], 100)
self.assertIsNotNone(memory_resource)
self.assertEqual(memory_resource["nominalQuota"], "100Gi")
resource_flavor = next(
(doc for doc in manifest_docs if doc["kind"] == "ResourceFlavor"), None
)
self.assertIsNotNone(resource_flavor)
self.assertEqual(
resource_flavor["spec"]["nodeLabels"][
"cloud.google.com/gke-tpu-accelerator"
],
"test-accelerator",
)
self.assertEqual(
resource_flavor["spec"]["nodeLabels"][
"cloud.google.com/gke-tpu-topology"
],
"2x2x1",
)
self.assertEqual(cluster_queue["spec"]["admissionChecks"][0], "dws-prov")

@patch("xpk.core.kueue_manager.KueueManager._KueueManager__apply_manifest")
@patch("xpk.core.kueue_manager.KueueManager._KueueManager__install")
Expand Down
Loading