Add support for shared TPU reservations #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SikaGrr
requested review from
FIoannides,
jamOne- and
scaliby
as code owners
|
🤖 Hi @SikaGrr, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
FIoannides
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables usage of shared reservations for TPU cluster creation.
Issue
Node pool can be created with reservations shared from projects different from cluster project (by supplying resource path): https://cloud.google.com/kubernetes-engine/docs/how-to/consuming-reservations#specific_shared
XPK workflows fail when full reservation path is used because they are trying to find them in the clusters' project.
This PR fixes that by parsing reservation and using appropriate project.
Testing
Added unit tests and a golden with a shared reservation.
Shared reservations with GPU clusters are not in the scope of this PR so this was not tested.