Skip to content

fix: include custom outputs in xlsx finalisation#383

Open
yell0w12 wants to merge 1 commit intoAI-SDC:mainfrom
yell0w12:fix-xlsx-custom-outputs
Open

fix: include custom outputs in xlsx finalisation#383
yell0w12 wants to merge 1 commit intoAI-SDC:mainfrom
yell0w12:fix-xlsx-custom-outputs

Conversation

@yell0w12
Copy link
Copy Markdown

Fixes #312.

This PR updates XLSX finalisation so custom outputs are copied into the output folder and listed in the generated description sheet, matching the behavior of JSON finalisation.

QA:

  • Reproduced the bug locally before the fix: JSON copied the custom output, while XLSX created results.xlsx but did not copy or list the custom output.
  • Confirmed the same reproduction case passes after the fix.
  • Added regression coverage to test_finalise_excel.
  • Ran pytest: 128 passed.
  • Ran prek run -a: all checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Custom outputs don't get included in the output folder when using xlsx option

1 participant