Validate release candidates earlier and add final release check#108
Merged
jexShain merged 1 commit intoAI-Shell-Team:mainfrom Apr 15, 2026
Merged
Conversation
…rmation Move the heaviest release validation onto the release candidate path by detecting release PRs in CI, running installed-binary runtime smoke checks, and validating artifact-based live smoke against installed bundles. Teach Release Preparation to validate an explicit ref so maintainers can run the full release candidate check before merge, then add a lightweight Release Final Check workflow that only confirms merged main state and release metadata before tagging. Also document the updated maintainer flow in CONTRIBUTING so the repository guidance matches the new pre-merge preparation and post-merge final confirmation model.
Contributor
|
Thanks for the pull request. A maintainer will review it when available. Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review. Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md |
github-actions
Bot
added
dependencies
Contributor
|
This pull request description looks incomplete. Please update the missing sections below before review. Missing items:
|
jexShain
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the heaviest release verification onto the release-candidate path and splits the post-merge release confirmation into a lightweight final check.
What Changed
packaging/scripts/smoke-installed-aish.shand wire it into CI and local binary build verification.Release Preparationto validate an explicitref, so maintainers can run the full release candidate check before merge.Release Final Checkworkflow that only confirms mergedmainstate and release metadata before tagging.Why
The old flow still left a gap where the release PR could merge before the repository had validated the installed artifact path that would actually be shipped. This PR closes that gap by running the heavy artifact-based validation before merge, while keeping a small post-merge confirmation step so tagging stays low-friction.
Validation