fix(llm): avoid interrupting reasoning display with streamed content#109
Merged
F16shen merged 1 commit intoAI-Shell-Team:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
|
Thanks for the pull request. A maintainer will review it when available. Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review. Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md |
Contributor
|
This pull request description looks incomplete. Please update the missing sections below before review. Missing items:
|
Only emit content_delta events during streaming when tool calls are present. For plain conversations the response is now rendered by the caller after the LLM operation completes, preventing the Live reasoning display from being disrupted. Also expose content_was_streamed property on PTYAIShell for clean cross-object access instead of getattr on private attributes.
6b80df7 to
2cc00a2
Compare
F16shen
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content_deltaevents during streaming when tool calls are present, preventing the reasoning Live display from being disrupted in plain conversationscontent_was_streamedproperty onPTYAIShellfor clean cross-object access, replacinggetattron private attributesemit_content_delta(is_final=True)in non-streaming path without tool callsTest plan