Skip to content

fix(plan): use Shift+Tab and Ctrl+X P toggle#110

Merged
F16shen merged 1 commit intoAI-Shell-Team:mainfrom
F16shen:fix/plan-mode-shortcuts
Apr 16, 2026
Merged

fix(plan): use Shift+Tab and Ctrl+X P toggle#110
F16shen merged 1 commit intoAI-Shell-Team:mainfrom
F16shen:fix/plan-mode-shortcuts

Conversation

@F16shen
Copy link
Copy Markdown
Collaborator

@F16shen F16shen commented Apr 16, 2026

Summary

This PR updates the interactive plan-mode toggle shortcuts in the shell editor so plan mode no longer depends on F2.

What Changed

  • Replaced the plan-mode toggle key binding in the shell editor with Shift+Tab
  • Added Ctrl+X, then P as a fallback toggle sequence
  • Updated the editor-level shortcut test to assert both bindings are registered
  • Left the actual toggle behavior unchanged; this only changes how the existing toggle is invoked

Notes

  • CHANGELOG.md is intentionally not updated in this PR. We will record this in the next version release work.
  • The plan-mode runtime behavior and state transitions are unchanged by this diff.

Validation

  • Ran pytest tests/shell/ui/test_shell_editor.py tests/shell/runtime/test_shell_pty_core.py
  • Result: 69 tests passed

Files Touched

  • src/aish/shell/ui/editor.py
  • tests/shell/ui/test_shell_editor.py

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the pull request. A maintainer will review it when available.

Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review.

Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

This pull request description looks incomplete. Please update the missing sections below before review.

Missing items:

  • User-visible Changes
  • Compatibility
  • Testing
  • Change Type
  • Scope

@F16shen F16shen merged commit 0e7afc9 into AI-Shell-Team:main Apr 16, 2026
10 checks passed
@F16shen F16shen deleted the fix/plan-mode-shortcuts branch April 16, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant