fix: always prefer sandbox IPC when enabled#57
Merged
F16shen merged 2 commits intoAI-Shell-Team:mainfrom Mar 17, 2026
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix sandbox path selection so privileged sandbox uses IPC consistently for both root and non-root callers.
Previously, the security manager only selected
SandboxSecurityIpcwhen the caller was non-root. That caused root callers to bypass the sandbox daemon and execute the local sandbox path directly, which diverged from the intended design where root is only responsible for starting the sandbox service process.Problem
The current implementation introduced an unintended split:
This was inconsistent with the intended design and made root-path failures harder to reason about and reproduce consistently across environments.
Changes
src/aish/security/security_manager.pyso IPC is always preferred when privileged sandbox is enabledtests/security/sandbox/test_ipc.pyto verify:SandboxSecurityIpcwhen privileged sandbox is enabledSandboxSecurityis only used when privileged sandbox is explicitly disabledValidation
Passed:
pytest tests/security/sandbox/test_ipc.py