aish supports shell prompts#66
Merged
F16shen merged 3 commits intoAI-Shell-Team:mainfrom Mar 19, 2026
Merged
Conversation
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
requested changes
Mar 19, 2026
Collaborator
F16shen
left a comment
There was a problem hiding this comment.
这轮 review 里我主要有几项阻塞点:
enable_scripts目前是默认开启并且会把旧配置自动迁移成开启状态,这会让现有用户无感切到新的 prompt/script 路径,和 PR 描述里的手动启用预期不一致。- 脚本 hot reload 的启动时序有问题,首次启动时如果
scripts目录还不存在,watcher 会直接退出,默认 prompt 模板也无法在当前会话里生效。 - prompt 失败态依赖进程环境里的
?,但当前 shell 没有看到有地方可靠维护它,这会让 prompt 状态不可信。 handle_script_call()里OLDPWD会被写成新目录而不是旧目录。- 脚本调用优先级高于普通命令,会直接遮蔽同名系统命令。
ScriptExecutor当前是按行解释脚本,和用户对 shell 脚本语义的预期差异很大,现有测试也还没有覆盖这些高风险场景。
我已经把这些点分别挂到了对应代码行上,建议先把这些基础语义和兼容性问题收敛之后再继续推进。
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
reviewed
Mar 19, 2026
F16shen
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modify this configuration file to turn on this function
~/.config/aish/config.yaml
Change Type
Scope
User-visible Changes
Compatibility
Testing
Checklist