Skip to content

Optimize packaging and loading of default .aish files#73

Merged
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
jexShain:main
Mar 20, 2026
Merged

Optimize packaging and loading of default .aish files#73
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
jexShain:main

Conversation

@jexShain
Copy link
Copy Markdown
Collaborator

Summary

  • Problem:Optimize packaging and loading of default .aish files
  • Changes:
  • Related Issue: #

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Other

Scope

  • Core shell / PTY
  • AI agent / LLM
  • Skills / Tools
  • Security
  • Configuration
  • CLI / Interface
  • Packaging / Installation
  • CI/CD
  • Documentation

User-visible Changes

Compatibility

  • Backward compatible? (Yes/No)
  • Config changes? (Yes/No - if yes, describe migration)

Testing

Checklist

  • Code follows project style
  • Tests added if needed
  • Documentation updated if needed

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR shifts default “prompt/script” assets and skill packaging away from in-package builtin_skills toward system data directories, and adds startup initialization to copy default .aish prompt scripts into the user scripts directory.

Changes:

  • Remove built-in skill root discovery from SkillManager (skills now expected to be present under the user skills directory, seeded by packaging/install).
  • Add config startup initialization to copy default .aish prompt scripts from system locations into the user scripts directory (best-effort, non-overwriting).
  • Update packaging/install to ship prompt scripts and templates via Makefile + PyInstaller datas, and add a new packaged Debian skill (prompt-designer).

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/aish/skills/manager.py Removes built-in skill discovery; only USER and CLAUDE roots remain.
src/aish/config.py Adds _init_scripts_dir() to copy default .aish prompt scripts from system locations into user scripts dir at startup.
src/aish/builtin_skills/script-manager/SKILL.md Removes bundled script-manager skill content.
src/aish/builtin_skills/script-generator/SKILL.md Removes bundled script-generator skill content.
src/aish/builtin_skills/init.py Removes builtin_skills package marker/docstring.
debian/skills/prompt-designer/SKILL.md Adds a new Debian-packaged skill describing prompt customization workflow.
aish.spec Adds PyInstaller data inclusion for src/aish/scripts/prompts and src/aish/scripts/templates.
Makefile Installs prompt .aish files into $(DATADIR)/prompts and templates into $(DATADIR)/scripts/templates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/aish/skills/manager.py
Comment thread src/aish/config.py
Comment thread src/aish/config.py
@F16shen F16shen merged commit ec8ac54 into AI-Shell-Team:main Mar 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config core packaging Packaging or installation issue size: L skills Skills-related issue tests trusted-contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants