Optimize packaging and loading of default .aish files#73
Merged
F16shen merged 2 commits intoAI-Shell-Team:mainfrom Mar 20, 2026
Merged
Optimize packaging and loading of default .aish files#73F16shen merged 2 commits intoAI-Shell-Team:mainfrom
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR shifts default “prompt/script” assets and skill packaging away from in-package builtin_skills toward system data directories, and adds startup initialization to copy default .aish prompt scripts into the user scripts directory.
Changes:
- Remove built-in skill root discovery from
SkillManager(skills now expected to be present under the user skills directory, seeded by packaging/install). - Add config startup initialization to copy default
.aishprompt scripts from system locations into the user scripts directory (best-effort, non-overwriting). - Update packaging/install to ship prompt scripts and templates via Makefile + PyInstaller datas, and add a new packaged Debian skill (
prompt-designer).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aish/skills/manager.py | Removes built-in skill discovery; only USER and CLAUDE roots remain. |
| src/aish/config.py | Adds _init_scripts_dir() to copy default .aish prompt scripts from system locations into user scripts dir at startup. |
| src/aish/builtin_skills/script-manager/SKILL.md | Removes bundled script-manager skill content. |
| src/aish/builtin_skills/script-generator/SKILL.md | Removes bundled script-generator skill content. |
| src/aish/builtin_skills/init.py | Removes builtin_skills package marker/docstring. |
| debian/skills/prompt-designer/SKILL.md | Adds a new Debian-packaged skill describing prompt customization workflow. |
| aish.spec | Adds PyInstaller data inclusion for src/aish/scripts/prompts and src/aish/scripts/templates. |
| Makefile | Installs prompt .aish files into $(DATADIR)/prompts and templates into $(DATADIR)/scripts/templates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change Type
Scope
User-visible Changes
Compatibility
Testing
Checklist