Skip to content

Refactor ask_user interactions#83

Merged
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
F16shen:refactor/ask_user
Mar 27, 2026
Merged

Refactor ask_user interactions#83
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
F16shen:refactor/ask_user

Conversation

@F16shen
Copy link
Copy Markdown
Collaborator

@F16shen F16shen commented Mar 26, 2026

Summary

Refactor ask_user to use a structured interaction model and a single shell UI path.

Motivation

ask_user had accumulated legacy compatibility logic and mode-specific UI handling over time. In practice, that caused inconsistent behavior across interaction types, blurred ownership between the tool layer and shell layer, and made it harder to support both strict selection and free-form input cleanly.

This change simplifies the model and makes the interaction flow easier to reason about and extend.

Changes

  • introduce structured interaction request/response types
  • migrate ask_user onto explicit interaction kinds:
    • single_select
    • text_input
    • choice_or_text
  • unify shell-side ask_user handling behind one prompt UI flow
  • remove obsolete inline-specific interaction code and stale config
  • update tool guidance, docs, and regression coverage

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the pull request. A maintainer will review it when available.

Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review.

Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2026

This pull request description looks incomplete. Please update the missing sections below before review.

Missing items:

  • User-visible Changes
  • Compatibility
  • Testing
  • Change Type
  • Scope

@github-actions github-actions Bot added docs pty PTY or interactive process issue core agent Agent or LLM workflow issue tools config tests i18n skills Skills-related issue size: XL experienced-contributor labels Mar 26, 2026
@F16shen F16shen requested a review from jexShain March 26, 2026 10:02
@F16shen F16shen merged commit d156c9e into AI-Shell-Team:main Mar 27, 2026
10 checks passed
@F16shen F16shen deleted the refactor/ask_user branch April 1, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Agent or LLM workflow issue config core docs experienced-contributor i18n pty PTY or interactive process issue size: XL skills Skills-related issue tests tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants