feat: improve ask_user and remove unfinished plan module#84
Merged
F16shen merged 2 commits intoAI-Shell-Team:mainfrom Mar 27, 2026
Merged
feat: improve ask_user and remove unfinished plan module#84F16shen merged 2 commits intoAI-Shell-Team:mainfrom
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
Conversation
github-actions
Bot
added
pty
Contributor
|
Thanks for the pull request. A maintainer will review it when available. Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review. Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md |
Contributor
|
This pull request description looks incomplete. Please update the missing sections below before review. Missing items:
|
jexShain
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR makes two focused changes to improve reliability and keep scope clear:
Improve ask_user interaction flow
The previous interaction model and UX were inconsistent in practice. This update simplifies interaction kinds and makes option/custom input behavior more predictable.
Remove the current plan module
The existing plan implementation is not production-ready and was creating UX and maintenance overhead. Removing it now avoids shipping fragile behavior and gives us a clean baseline for a future redesign.
Scope