Skip to content

CI: Tighten live smoke tool verification#90

Merged
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
F16shen:copilot/live-smoke-tool-check-fallback
Apr 3, 2026
Merged

CI: Tighten live smoke tool verification#90
F16shen merged 2 commits intoAI-Shell-Team:mainfrom
F16shen:copilot/live-smoke-tool-check-fallback

Conversation

@F16shen
Copy link
Copy Markdown
Collaborator

@F16shen F16shen commented Apr 3, 2026

Summary

  • make live smoke fail fast when a custom API base is paired with a bare model name
  • align check-tool-support with the runtime auto tool-calling path instead of probing required mode
  • add regression coverage for the verification behavior

Testing

  • /home/lixin/workspace/aishell/aish/.venv/bin/python -m pytest tests/test_verification.py tests/live_smoke/conftest.py -q
  • /home/lixin/workspace/aishell/aish/.venv/bin/python -m pytest tests/test_provider_registry.py tests/test_cli.py tests/test_verification.py -q
  • AISH_LIVE_SMOKE_MODEL=openai/gpt-5.1 AISH_LIVE_SMOKE_API_BASE=http://www.aishell.ai:8080/aitest/v1 AISH_LIVE_SMOKE_API_KEY=*** make test-live-smoke

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Thanks for the pull request. A maintainer will review it when available.

Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review.

Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

This pull request description looks incomplete. Please update the missing sections below before review.

Missing items:

  • User-visible Changes
  • Compatibility
  • Change Type
  • Scope

@F16shen F16shen changed the title Tighten live smoke tool verification CI: Tighten live smoke tool verification Apr 3, 2026
@F16shen F16shen merged commit cf015f5 into AI-Shell-Team:main Apr 3, 2026
11 checks passed
@F16shen F16shen deleted the copilot/live-smoke-tool-check-fallback branch April 8, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant