-
Notifications
You must be signed in to change notification settings - Fork 61
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
fairness_evaluation.py and score_calculation_script.py have over 100 lines of mostly identical code. However, score_calculation_script.py calculates numbers differently from fairness_evaluation.py. An ordinary user might find this confusing. The two branches from if args.dry_run: are also repetitive.
Describe the solution you'd like
- Refactor the score calculation part in
fairness_evaluation.pyintoscore_calculation_script.py. get_pathfunction is also weird. Canos.path.dirnamedo its job?- Merge the two branches from
if args.dry_run:are also repetitive. Since fairness needs a specialdo_classification. I added a monkey patch (Line 173). Whether to activate the monkey patch or not can be determined based on whether we are running dry runs. This should be much cleaner once we fully adopt the return object, so we don't need to return a bunch of tuples...
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request