feat: add support for studio async client #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josephasafg
requested changes
Jun 6, 2024
|
|
||
| return await self._client.send(request=request, stream=stream) | ||
|
|
||
| data = self._get_data(files=files, method=method, params=params) |
There was a problem hiding this comment.
This also mutates the headers which is weird and un-expectable don't you think?
Josephasafg
reviewed
Jun 10, 2024
| @@ -0,0 +1,6 @@ | |||
| CHAT_DEFAULT_NUM_RESULTS = 1 | |||
There was a problem hiding this comment.
Since its under the studio package, no need to call the file studio_constants.py - constants.py should suffice :)
Josephasafg
reviewed
Jun 10, 2024
ai21/http_client/base_http_client.py
Outdated
| return json.dumps(body).encode() if body else None | ||
|
|
||
| def _get_request_headers(self, files: Optional[Dict[str, BinaryIO]]) -> Dict[str, Any]: | ||
| headers = self._headers.copy() |
There was a problem hiding this comment.
Instead of mutating the dict, a better way to do this is to create a new header object. Something like -
def _get_request_headers(self, files: Optional[Dict[str, BinaryIO]]) -> Dict[str, Any]:
if files is not None and "Content-Type" in self._headers:
return {key: value for key, value in self._headers.items() if key != "Content-Type"}
return self._headers
Josephasafg
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.