-
Notifications
You must be signed in to change notification settings - Fork 12
fix: skip passing API key to ARN endpoint #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,34 @@ | ||
| import pytest | ||
|
|
||
| from ai21 import SageMaker | ||
| from tests.integration_tests.skip_helpers import should_skip_studio_integration_tests | ||
| from ai21 import SageMaker, AI21EnvConfig | ||
|
|
||
|
|
||
| @pytest.mark.skipif(should_skip_studio_integration_tests(), reason="No key supplied for AI21 Studio. Skipping.") | ||
| def test_sagemker__get_model_package_arn(): | ||
| def _add_or_remove_api_key(use_api_key: bool): | ||
| if use_api_key: | ||
| AI21EnvConfig.api_key = "test" | ||
| else: | ||
| AI21EnvConfig.api_key = None | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| argnames="use_api_key", | ||
| argvalues=[True, False], | ||
| ids=["with_api_key", "without_api_key"], | ||
| ) | ||
| def test_sagemaker__get_model_package_arn(use_api_key: bool): | ||
| _add_or_remove_api_key(use_api_key) | ||
| model_packages_arn = SageMaker.get_model_package_arn(model_name="j2-mid", region="us-east-1") | ||
| assert isinstance(model_packages_arn, str) | ||
| assert len(model_packages_arn) > 0 | ||
|
|
||
|
|
||
| @pytest.mark.skipif(should_skip_studio_integration_tests(), reason="No key supplied for AI21 Studio. Skipping.") | ||
| def test_sagemker__list_model_package_versions(): | ||
| @pytest.mark.parametrize( | ||
| argnames="use_api_key", | ||
| argvalues=[True, False], | ||
| ids=["with_api_key", "without_api_key"], | ||
| ) | ||
| def test_sagemaker__list_model_package_versions(use_api_key: bool): | ||
| _add_or_remove_api_key(use_api_key) | ||
| model_packages_arn = SageMaker.list_model_package_versions(model_name="j2-mid", region="us-east-1") | ||
| assert isinstance(model_packages_arn, list) | ||
| assert len(model_packages_arn) > 0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test where we set an env variable of
AI21_API_KEYto validates that it still works?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍