Skip to content

fix: Pass model id in Bedrock client init #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2024
Merged

fix: Pass model id in Bedrock client init #71

merged 4 commits into from
Feb 25, 2024

Conversation

@asafgardin
Copy link
Contributor

@asafgardin asafgardin commented Feb 23, 2024

  • Pass in init
  • Check for the model_id in create as well. If passed, use the one that's passed in create just for that single call

etang-ai21
etang-ai21 reviewed Feb 24, 2024
View reviewed changes
etang-ai21
etang-ai21 reviewed Feb 24, 2024
View reviewed changes
etang-ai21
etang-ai21 reviewed Feb 24, 2024
View reviewed changes
@asafgardin asafgardin merged commit 409e818 into main Feb 25, 2024
@asafgardin asafgardin deleted the pass_bedrock_model_id_in_ctor branch February 25, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etang-ai21 etang-ai21 etang-ai21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asafgardin @etang-ai21