-
Notifications
You must be signed in to change notification settings - Fork 18
enhancement: introduce js/ts UI #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…: add /diagram endpoint; config: dev proxy and WASM plugins
…ix node UI deploy path
ajbozarth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An initial code review pass on the cli updates. I'll be checking out and trying it locally while doing the code review of the UI code next
|
Also worth noting that #719 added a mcp server that may need updating in addition to the CLI. (especially if the cli is moved out of maestro to maestro-cli and calls that mcp server, as I believe is the plan) |
ajbozarth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running locally is not working as mentioned in the comments below, but here's some more code review for the UI code. I did not take a deep look into the typescript code yet, just it's functionality
|
ok, i think I have addressed most of the comments, and left the ones that are unresolved as issues i will open, or reminders on small things to fix. hopefully my updated readme instructions work to help you see the UI; I tested it in a clean environment and wrote it based on that |
|
@ajbozarth @maximilien if you have extra time, lmk if you can start the actual website (the api itself may not be working due depending on your .env and local models downloaded in ollama). you can test for example: shut down script I wrote to be in the |
I'll try to get to this by this afternoon |
george-lhj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ajbozarth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test locally and following the README I was able to get it working, given this is a first pass I won't block on UI issues and just list some here below:
- the output box centers the text instead of left justify, which causes visual oddities
- the output section should probably do markdown formatting
- you can't click enter to submit a query
- the query filed isn't cleared after submitting
Separate from the UI though I also raised some comments in the README, specifically one about how the extra install step might be an issue when deploying maestro
Also don't forget some of my old comments before we merge this (like the change in model comment)
|
Issues to open:
|
Signed-off-by: George Liu <142549635+george-lhj@users.noreply.github.com>
|
Pending these issues I'll open, is this ok to merge? @ajbozarth |
ajbozarth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending opening the follow up issues listed above this LGTM

fixes #714
Add new Node/TypeScript UI for workflows (web/maestro-ui):
CLI updates:
maestro deploy tests/yamls/agents/openai_agent.yaml tests/yamls/workflows/openai_mcp_workflow.yaml --node-uimaestro cleanNode UI deploy starts FastAPI and the UI; Streamlit unchanged by default
Docs:
Minimal README in web/maestro-ui with dev/prod usage and stop instructions
Notes: