Make sure test environment points to the correct place #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
hegner
approved these changes
Sep 23, 2024
Collaborator
hegner
left a comment
hegner
left a comment
There was a problem hiding this comment.
If tests run through, I'll merge. thanks!
Collaborator
Author
|
The key4hep based one will likely fail: key4hep/key4hep-spack#651 edit: Looks like pre-commit also doesn't fully work |
Collaborator
|
The pre-commit looks very strange, but unrelated to this change. Key4hep worked though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ROOT_INCLUDE_PATHin the test environment points to the correct place.ENDRELEASENOTES
Should point into the source tree not the build tree (where the pointed to place does not exist).