Make sure that link weights are stored in a struct #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise ROOT does something clever and simply stores the float without the struct. Which makes the switch over a bit less transparent.
3 tasks
Collaborator
Author
|
Merging this now and #691 on Monday next week, unless someone speaks up against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise ROOT does something clever and simply stores the float without the struct. Which makes the switch over a bit less transparent.
BEGINRELEASENOTES
vector<LinkData>in the ROOT files instead of avector<float>ENDRELEASENOTES
Pulled this out of #691 as it is really an unrelated fix that has nothing to do with that.