Skip to content

Conversation

@tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Mar 5, 2025

BEGINRELEASENOTES

  • Fix the (potential) import error for podio.version.build_version by not relying on ROOTs JIT, but rather parsing the python __version__ into the correct type.

ENDRELEASENOTES

Fixes key4hep/key4hep-spack#670

@tmadlener tmadlener force-pushed the fix-python-build-version branch from 8cf70ed to 87355b0 Compare March 6, 2025 07:41
@tmadlener
Copy link
Collaborator Author

@andresailer @jmcarcell do I miss something obvious here, or should we just go ahead with this?

@jmcarcell
Copy link
Member

If you tried it and it fixes it then I guess it's good, I never knew why this happened and it disappears in the newer versions of ROOT. I even think I wasn't able to reproduce locally with the ROOT version that we have in the stack, it has always worked fine for me (I have been working with debug builds for a long time).

@tmadlener
Copy link
Collaborator Author

Things have been working nicely with me locally and it is a 1:1 replacement of the same thing, but now we construct it in python, rather than relying on ROOTs JIT.

I have been running with the other version for months now without issue, but yesterday it started failing even though the ROOT version is unchanged. Not sure if it's an issue in how podio builds and links things, or if it's something else. Anyhow with this it doesn't matter.

@tmadlener tmadlener force-pushed the fix-python-build-version branch from 87355b0 to e4bb2ba Compare March 6, 2025 10:37
@tmadlener tmadlener force-pushed the fix-python-build-version branch from e4bb2ba to 8603e8b Compare March 6, 2025 12:43
@tmadlener tmadlener merged commit 896b27a into AIDASoft:master Mar 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants