Add ugly code to trigger an error when reading garbage #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Sep 19, 2025
Collaborator
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
Is there a conceivable way to test that this truly triggers? Not sure how we would realistically get the garbage data, but maybe creating a faulty file with a slightly different EDM and then trying to read it similar as we do for the backwards compatibility tests?
jmcarcell
force-pushed
the
add-read-garbage-fix
branch
from
363ea4b to
281fa7f
Compare
Member
Author
|
I think the test is working now with either the exception or a crash. I'm not sure if this will hold in the future with newer compilers. |
tmadlener
reviewed
Oct 14, 2025
jmcarcell
force-pushed
the
add-read-garbage-fix
branch
from
b64cd4a to
b9c3887
Compare
This prevents an infinite loop from happening and consuming all the memory.
Tested on GCC 15 and Clang 20 with all the combinations of
{Debug,RelWithDebInfo,Release} builds, in 5 out of 6 it triggers one of the
errors and with GCC in Debug it crashes from ROOT.
At least one happening with GCC < 15
tmadlener
force-pushed
the
add-read-garbage-fix
branch
from
b9c3887 to
cdf0b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
This prevents an infinite loop from happening and consuming all the memory. Tested on GCC 15 and Clang 20 with all the combinations of {Debug,RelWithDebInfo,Release} builds, in 5 out of 6 it triggers one of the errors and with GCC in Debug it crashes from ROOT.
I think that
sis a random 64 bit number (or at least it was big one when I checked with gdb), so the probability of not triggering the error should 1e15/2**64=5e-5 if this is true.To test, from the build directory:
export ROOT_LIBRARY_PATH=$PWD/testsbefore #841 is merged.