Add unit tests for JSON serialization#941
Conversation
|
Please drop the two commits from the TransportFrameData PR |
tmadlener
left a comment
There was a problem hiding this comment.
Thanks a lot. Seconding the comment from @andresailer to drop the TransportFrameData commit(s) from this PR to have it only contain JSON related things.
A few more comments / suggestions inline.
250e65d to
8546550
Compare
|
Thanks for the detailed review, |
tmadlener
left a comment
There was a problem hiding this comment.
It loosk like you picked up a few files that are generated by cmake in your last commit. Please remove them again.
tests/CMakeFilesas a wholetests/unittests/CMakeCachetests/CMakeLists.txt.savetests/tmp_peering_forward.pdf
|
Thanks for pointing this out. |
|
hey , |
Why do you think there are comments on the files in this PR to remove them, if they were not tracked in the repository? |
|
I have removed the accidentally committed generated files. |
tmadlener
left a comment
There was a problem hiding this comment.
Thanks a lot for cleaning up. There are a few more minor things that could be improved (and that became more easily visible now that the "noise" has been cut down).
|
Thanks for the suggestions |
852c1e6 to
95f451b
Compare
|
Please make sure you squash the commits to remove those accidentally committed files from the history. |
95f451b to
0f79557
Compare
0f79557 to
93fcb84
Compare
tests: address review comments for JSON serialization tests tests: address review comments for JSON serialization tests tests: remove accidentally committed CMake generated files tests: remove accidentally committed CMake generated files tests: simplify json dependency configuration tests: simplify json dependency configuration tests: address review comments for JSON serialization tests
93fcb84 to
c1cfd51
Compare
|
Fun fact: if you want to reduce compile times of podio or EDM4hep-related, the easiest and probably only practical thing you can do is to compile without json, everything else is the standard library and not much can be done. |
This PR adds unit tests covering the JSON serialization functionality.
The tests verify that expected fields are correctly serialized to JSON,
following the discussion in #517. The tests run entirely in memory and
check that struct members are properly converted to JSON.
Closes #517