[Bugfix]Fix the tau2 bench metrics display in pass^k situation#272
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the evaluation result dumping logic to include pass rates for all trial counts and modifies the configuration to use dynamic summary group names. Feedback suggests improving robustness by using .get() when accessing the metrics dictionary to avoid potential KeyError exceptions and ensuring the correct trial count is referenced for each dataset in the configuration list comprehension.
| for k in range(1, self.run_config.num_trials + 1): | ||
| results[f"pass^{k}"] = 100 * self.captured_metrics.pass_hat_ks[k] |
There was a problem hiding this comment.
The loop assumes that self.captured_metrics.pass_hat_ks contains all keys from 1 to num_trials. If the simulation results are incomplete or if compute_metrics returns a partial set of metrics, this will raise a KeyError. It is safer to use .get() or check for the key's existence before access to ensure robustness against partial evaluation results.
| for k in range(1, self.run_config.num_trials + 1): | |
| results[f"pass^{k}"] = 100 * self.captured_metrics.pass_hat_ks[k] | |
| for k in range(1, self.run_config.num_trials + 1): | |
| val = self.captured_metrics.pass_hat_ks.get(k) | |
| if val is not None: | |
| results[f"pass^{k}"] = 100 * val |
| @@ -103,8 +103,8 @@ | |||
| _all_sub_set = [(ds_config["abbr"], f'pass^{datasets[0]["args"]["num_trials"]}') for ds_config in datasets] | |||
There was a problem hiding this comment.
Using datasets[0] inside the list comprehension is fragile and potentially incorrect if different datasets have different trial counts. It is better to use the loop variable ds_config to ensure the correct num_trials is used for each subset, making the configuration more robust and accurate for heterogeneous dataset groups.
| _all_sub_set = [(ds_config["abbr"], f'pass^{datasets[0]["args"]["num_trials"]}') for ds_config in datasets] | |
| _all_sub_set = [(ds_config["abbr"], f'pass^{ds_config["args"]["num_trials"]}') for ds_config in datasets] |
Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。
PR Type / PR类型
Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)
🔍 Motivation / 变更动机
Please describe the motivation of this PR and the goal you want to achieve through this PR.
请描述您的拉取请求的动机和您希望通过此拉取请求实现的目标。
Fix the tau2 bench metrics display in pass^k situation
📝 Modification / 修改内容
Please briefly describe what modification is made in this PR.
请简要描述此拉取请求中进行的修改。
Fix the tau2 bench metrics display in pass^k situation
📐 Associated Test Results / 关联测试结果
Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。
Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。
If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。
🌟 Use cases (Optional) / 使用案例(可选)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。
✅ Checklist / 检查列表
Before PR:
After PR:
👥 Collaboration Info / 协作信息
🌟 Useful CI Command / 实用的CI命令
/gemini review/gemini summary/gemini help/readthedocs build