Skip to content

【UT】补充realworldqa相关ut测试用例#287

Merged
Keithwwa merged 1 commit into
AISBench:masterfrom
wanlongze:ut_realworldqa
May 8, 2026
Merged

【UT】补充realworldqa相关ut测试用例#287
Keithwwa merged 1 commit into
AISBench:masterfrom
wanlongze:ut_realworldqa

Conversation

@wanlongze

Copy link
Copy Markdown
Contributor

Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。

PR Type / PR类型

  • Test-Cases(测试用例更新)

Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)

🔍 Motivation / 变更动机

Please describe the motivation of this PR and the goal you want to achieve through this PR.
请描述您的拉取请求的动机和您希望通过此拉取请求实现的目标。

📝 Modification / 修改内容

补充对于realworldQA数据集的UT测试用例

📐 Associated Test Results / 关联测试结果

Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。

⚠️ BC-breaking (Optional) / 向后不兼容变更(可选)

Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。

⚠️ Performance degradation (Optional) / 性能下降(可选)

If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。

🌟 Use cases (Optional) / 使用案例(可选)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。

✅ Checklist / 检查列表

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues. / 使用预提交或其他 linting 工具来修复潜在的 lint 问题。
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests. / 修复的 Bug 已完全由单元测试覆盖,导致 Bug 的情况应在单元测试中添加。
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness. / 此拉取请求中的修改已完全由单元测试覆盖。如果不是,请添加更多单元测试以确保正确性。
  • All relevant documentation (API docs, docstrings, example tutorials) has been updated to reflect these changes. / 所有相关文档(API 文档、文档字符串、示例教程)已更新以反映这些更改。

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects. / 如果此拉取请求对下游或其他相关项目有潜在影响,应在那些项目中测试此 PR。
  • CLA has been signed and all committers have signed the CLA in this PR. / CLA 已签署,且本 PR 中的所有提交者均已签署 CLA。

👥 Collaboration Info / 协作信息

  • Suggested Reviewers / 建议审核人: @xxx
  • Relevant Module Owners / 相关模块负责人: @xxx
  • Other Collaboration Notes / 其他协作说明:

🌟 Useful CI Command / 实用的CI命令

Command / 命令 Introduction / 介绍
/gemini review Performs a code review for the current pull request in its current state by Gemini. / 对当前拉取请求在当前状态下由 Gemini 执行代码审核。
/gemini summary Provides a summary of the current pull request in its current state by Gemini. / 对当前拉取请求在当前状态下由 Gemini 提供摘要。
/gemini help Displays a list of available commands of Gemini. / 显示 Gemini 可用命令的列表。
/readthedocs build Triggers a build of the documentation for the current pull request in its current state by Read the Docs. / 触发当前拉取请求在当前状态下由 Read the Docs 构建文档。

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive suite of unit tests for the RealworldQAEvaluator class, covering answer extraction, normalization, and scoring logic. Feedback suggests refactoring the test class to use a setUp method for evaluator initialization to reduce redundancy. Additionally, a potential issue was identified in the answer extraction logic where internal tags like are incorrectly included in the output, requiring a fix to the extraction regex or logic.

Comment on lines +9 to +14
class TestRealworldQAEvaluator(unittest.TestCase):

def test_extract_answer_with_answer_tag(self):
evaluator = RealworldQAEvaluator()
result = evaluator._extract_answer("The car is red.\nANSWER: red")
self.assertEqual(result, "red")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

在每个测试方法中重复实例化 RealworldQAEvaluator 会导致代码冗余。建议使用 setUp 方法来初始化 evaluator 实例,以提高代码的可维护性。请注意,应用此更改后,需要将后续测试方法中的 evaluator 替换为 self.evaluator

Suggested change
class TestRealworldQAEvaluator(unittest.TestCase):
def test_extract_answer_with_answer_tag(self):
evaluator = RealworldQAEvaluator()
result = evaluator._extract_answer("The car is red.\nANSWER: red")
self.assertEqual(result, "red")
class TestRealworldQAEvaluator(unittest.TestCase):
def setUp(self):
self.evaluator = RealworldQAEvaluator()
def test_extract_answer_with_answer_tag(self):
result = self.evaluator._extract_answer("The car is red.\nANSWER: red")
self.assertEqual(result, "red")

Comment on lines +43 to +44
result = evaluator._extract_answer("<think>ANSWER: A, no wait...</think>\nANSWER: B")
self.assertEqual(result, "A, no wait...</think>")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

test_extract_answer_with_think_tags 中,预期的提取结果 "A, no wait...</think>" 包含了结束标签 </think>。这通常表明 _extract_answer 的正则表达式匹配逻辑存在缺陷,未能正确处理推理标签(如 <think>)的边界。建议优化提取逻辑以剥离此类标签,并更新测试用例以反映预期的干净输出。

@Keithwwa Keithwwa merged commit d0a6697 into AISBench:master May 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants