[feature][for merge][part1] Support terminal-bench-2#318
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for evaluating Terminal-Bench 2.0 in AISBench using the Harbor framework, which includes adding comprehensive documentation in both English and Chinese, updating the README files, and adding the harbor dependency. The code review identified a critical unresolved git merge conflict in the SWE-Bench configuration file, a hardcoded local user directory path in the Chinese documentation, and a copy-paste phrasing error in the English README.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <<<<<<< HEAD | ||
| path="", # necessary for mini datasets, get dataset from https://modelers.cn/datasets/AISBench/SWE-Bench_Multilingual_mini | ||
| ======= | ||
| path="", # Set local path to the mini dataset. Download from https://modelers.cn/datasets/AISBench/SWE-Bench_Multilingual_mini | ||
| >>>>>>> master_center |
There was a problem hiding this comment.
Unresolved git merge conflict markers found in this configuration file. This will cause a SyntaxError when the file is loaded or executed. Please resolve the conflict and remove the markers.
path="", # Set local path to the mini dataset. Download from https://modelers.cn/datasets/AISBench/SWE-Bench_Multilingual_mini| dict( | ||
| abbr='harbor_terminal-bench-2', | ||
| args=dict( | ||
| path="/home/y30044005/yh_dev/terminal-bench-2/", |
There was a problem hiding this comment.
The dataset path is hardcoded to a local user directory (/home/y30044005/yh_dev/terminal-bench-2/). Please use a generic placeholder like /path/to/terminal-bench-2/ to match the English documentation and avoid exposing local environment paths.
| path="/home/y30044005/yh_dev/terminal-bench-2/", | |
| path="/path/to/terminal-bench-2/", |
| > **⭐️Star this project** to get the latest updates of AISBench Benchmark Tool in real time! | ||
|
|
||
| ## 🔥 Latest Updates | ||
| - **\[2026.5.30\]** Support for evaluating Terminal-Bench 2.0 in AISBench, significantly reducing evaluation costs 🔥🔥🔥. Search for the `mini` keyword in the corresponding evaluation documentation: |
There was a problem hiding this comment.
The phrase 'Search for the mini keyword in the corresponding evaluation documentation:' seems to be a copy-paste artifact from the previous bullet point. It would be clearer to say 'See the corresponding evaluation documentation for details:' or similar.
| - **\[2026.5.30\]** Support for evaluating Terminal-Bench 2.0 in AISBench, significantly reducing evaluation costs 🔥🔥🔥. Search for the `mini` keyword in the corresponding evaluation documentation: | |
| - **\[2026.5.30\]** Support for evaluating Terminal-Bench 2.0 in AISBench, significantly reducing evaluation costs 🔥🔥🔥. See the corresponding evaluation documentation for details: |
| dict( | ||
| abbr='harbor_terminal-bench-2', | ||
| args=dict( | ||
| path="/path/to/terminal-bench-2/", |
There was a problem hiding this comment.
【review】The dataset path is hardcoded to a local user directory (/home/y30044005/yh_dev/terminal-bench-2/). Please use a generic placeholder like /path/to/terminal-bench-2/ to match the English documentation and avoid exposing local environment paths.
|
|
||
| ## 🔥 最新进展 | ||
|
|
||
| - **\[2026.5.30]** 支持在AISBench中测评基于Harbor的Terminal-Bench 2.0，并支持mini数据集，大幅降低评测成本🔥🔥🔥。示例与说明见 [在AISBench中测评基于Harbor的Terminal-Bench 2.0](https://ais-bench-benchmark.readthedocs.io/zh-cn/latest/extended_benchmark/agent/harbor_bench.html)。 |
There was a problem hiding this comment.
【review】The phrase 'Search for the mini keyword in the corresponding evaluation documentation:' seems to be a copy-paste artifact from the previous bullet point. It would be clearer to say 'See the corresponding evaluation documentation for details:' or similar.
| > **⭐️Star this project** to get the latest updates of AISBench Benchmark Tool in real time! | ||
|
|
||
| ## 🔥 Latest Updates | ||
| - **\[2026.5.30\]** Support for evaluating Terminal-Bench 2.0 in AISBench, significantly reducing evaluation costs 🔥🔥🔥. Search for the `mini` keyword in the corresponding evaluation documentation: |
There was a problem hiding this comment.
【review】The phrase 'Search for the mini keyword in the corresponding evaluation documentation:' seems to be a copy-paste artifact from the previous bullet point. It would be clearer to say 'See the corresponding evaluation documentation for details:' or similar.
2 participants
Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献，我们非常重视。以下说明将使您的拉取请求更健康，更易于获得反馈。如果您不理解某些项目，请不要担心，只需提交拉取请求并从维护人员那里寻求帮助即可。
PR Type / PR类型
Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)
🔍 Motivation / 变更动机
Please describe the motivation of this PR and the goal you want to achieve through this PR.
请描述您的拉取请求的动机和您希望通过此拉取请求实现的目标。
#314
📝 Modification / 修改内容
Please briefly describe what modification is made in this PR.
请简要描述此拉取请求中进行的修改。
📐 Associated Test Results / 关联测试结果
Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接，例如 CI 管道、测试报告等。
Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改？如果是，请描述它如何破坏兼容性，以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。
If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降，请描述性能下降的影响和预期的性能改进。
🌟 Use cases (Optional) / 使用案例（可选）
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能，最好在此处列出一些用例并更新文档。
✅ Checklist / 检查列表
Before PR:
After PR:
👥 Collaboration Info / 协作信息
🌟 Useful CI Command / 实用的CI命令
/gemini review/gemini summary/gemini help/readthedocs build