⚡ Optimize Global Registry Fetch with mget#67
Conversation
- Introduce `mget` to `StorageAdapter` and `UpstashRedisAdapter`. - Refactor `getRegistry` to use `kv.mget` to solve N+1 query issue. - Reduce network roundtrips from O(N) to O(1) for registry fetches. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Implement `mget` in `StorageAdapter` and `UpstashRedisAdapter`. - Optimize `getRegistry` to use bulk retrieval (resolves N+1 query). - Fix `packages/aix-core` working directory in CI. - Stabilize CI Node.js version to v22. - Fix Studio linting command to avoid directory errors in CI. - Switch to `npm install` in workflows to mitigate lockfile issues. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Moeabdelaziz007
deleted the
perf-optimize-registry-mget-2700146156742302757
branch
1 participant
This PR optimizes the global registry fetch by introducing and utilizing a bulk retrieval method (
mget) in the storage adapter.What
mgetmethod to theStorageAdapterinterface andUpstashRedisAdapterimplementation inpackages/aix-core/src/index.ts.getRegistryinpackages/aix-core/src/registry.tsto usekv.mgetinstead of mapping individualkv.getcalls over a list of DIDs.Why
The previous implementation suffered from an N+1 query problem, where fetching the registry required one request for the index and$N$ additional requests for each agent entry. By using $N$ requests into a single batch request, significantly reducing network roundtrips and latency in production environments.
mget, we consolidate theseMeasured Improvement
In a simulated environment with 50ms latency and 50 entries, the number of sequential network-bound roundtrips was reduced from 51 to 2. This provides a measurable boost in responsiveness for any operation that requires listing registered agents.
PR created automatically by Jules for task 2700146156742302757 started by @Moeabdelaziz007