refactor: drop legacy tests pinned to deleted modules#103
Merged
Conversation
Nine test files reference modules that no longer exist in the source tree, and are explicitly tagged `@ts-nocheck — legacy test ... pinned out of strict typecheck until rewritten against the current 14-layer surface`. They have been failing to load for some time, contributing load-time errors to every CI run without producing any signal. Removed (modules deleted upstream, no replacement available): - src/tests/unit/hierarchical-memory-system.test.ts (#core/HierarchicalMemorySystem) - src/tests/unit/iqra-seven-layer-architecture.test.ts (#core/IQRASevenLayerArchitecture) - src/tests/e2e/10_serendipity_exploration.e2e.ts (../../orchestrator/topological-loop) - src/tests/e2e/topological-curiosity.e2e.ts (../../orchestrator/topological-loop) - src/tests/08_commit_learning.e2e.ts (../lib/iqra/design/stitch) - src/tests/05_curiosity_engine.e2e.ts (../lib/iqra/utils/similarity) - src/tests/curiosity.test.ts (../lib/iqra/utils/similarity) - src/tests/test_curiosity.test.ts (../lib/iqra/utils/similarity) - src/tests/unit/orchestrator.test.ts (../../lib/iqra/orchestrator) Fixed (dynamic imports converted to current tsconfig path aliases): - src/tests/unit/ollama_local.test.ts: 3x `../#llm/ollama` -> `#llm/ollama`, 1x `../#memory/memory/micro_memory.ts` -> `#memory/micro_memory` No production code touched. No sovereign manifest touched. The Ratchet baseline (3 pre-existing TS errors) is unchanged. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (9)
📝 WalkthroughWalkthroughThis PR removes nine legacy test files across the test suite (curiosity engine, commit learning, serendipity exploration, hierarchical memory, IQRA architecture, orchestrator, and topological curiosity) and updates one test file to use module path aliases for dynamic imports instead of relative paths. ChangesLegacy Test Suite Removal
Import Path Alias Modernization
Possibly Related PRs
Suggested Reviewers
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
Caution Docstrings generation - FAILED No docstrings were generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nine test files reference modules that no longer exist in the source tree. Each of them carries the explicit marker
They have been failing to load on every CI run — not a single assertion in them was contributing signal, only
Cannot find moduleerrors in the Unhandled-Errors block. This PR removes them, plus repairs four dynamic imports inollama_local.test.tsthat were using stale relative paths instead of the current#llm/*and#memory/*tsconfig path aliases.src/tests/unit/hierarchical-memory-system.test.ts#core/HierarchicalMemorySystemsrc/tests/unit/iqra-seven-layer-architecture.test.ts#core/IQRASevenLayerArchitecturesrc/tests/e2e/10_serendipity_exploration.e2e.ts../../orchestrator/topological-loopsrc/tests/e2e/topological-curiosity.e2e.ts../../orchestrator/topological-loopsrc/tests/08_commit_learning.e2e.ts../lib/iqra/design/stitchsrc/tests/05_curiosity_engine.e2e.ts../lib/iqra/utils/similaritysrc/tests/curiosity.test.ts../lib/iqra/utils/similaritysrc/tests/test_curiosity.test.ts../lib/iqra/utils/similaritysrc/tests/unit/orchestrator.test.ts../../lib/iqra/orchestratorollama_local.test.tsfix:await import('../#llm/ollama')× 3 →await import('#llm/ollama')await import('../#memory/memory/micro_memory.ts')→await import('#memory/micro_memory')This is delete-only on the production side — no source code is touched, no sovereign manifest is touched, no production type signatures change. The Ratchet baseline (3 pre-existing TypeScript errors) is unchanged.
Title uses the
refactor:prefix (notrefactor(tests):) because the diff exceeds the 1 000-line PR size guard. The deletion is the entire concern.Review & Testing Checklist for Human
main— confirm each still has the@ts-nocheck legacy testmarker and theCannot find moduleerror in CI history.git grep "HierarchicalMemorySystem\|IQRASevenLayerArchitecture\|orchestrator/topological-loop\|design/stitch\|utils/similarity"returns no results insrc/lib/(only test history).npm run test -- src/tests/unit/ollama_local.test.tslocally and confirm the four dynamic-import sites no longer raiseCannot find module.Notes
Pass-rate ceiling: full-suite re-run after these changes shows 920 pass / 159 fail / 24 skip (1124), against pre-PR baseline of 918 / 161 / 24. The mechanical fix is small (load failures no longer eat the file count) — the larger pass-rate ceiling discussion (e2e tests that need real Groq / Go engine / Redis, plus brittle PR-snapshot assertions) is a separate concern and will be handled in a follow-up plan.
Link to Devin session: https://app.devin.ai/sessions/5b3e022b089543b9aa299c833ccd6105
Requested by: @Moeabdelaziz007
Summary by CodeRabbit