Fix false-positive undefined variable on static property access#75
Merged
AJenbo merged 1 commit intoAJenbo:mainfrom Apr 8, 2026
Merged
Conversation
AJenbo
force-pushed
the
fix/static-property-undefined-var
branch
from
93d91f1 to
dcc56e1
Compare
AJenbo
approved these changes
Apr 8, 2026
Owner
|
Nice work, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing false-positive "undefined variable" warnings that fire on static property access like self::$prop, static::$prop, and ClassName::$prop. The
$propin these cases is a class member name, not a local variable, so the diagnostic shouldn't flag it. The fix distinguishes between the three Variable variants in the scope collector: Direct is a member name and gets skipped, while Indirect (self::$$prop) and Nested (self::${expr}) do reference local variables and are still checked. Both the read and write paths are updated.