fix: harden docker-compose credentials and add api memory limit#46
Merged
Conversation
atkaridarshan04
added
bug
AK11105
reviewed
May 20, 2026
Owner
There was a problem hiding this comment.
better placeholder values can exist imo
AK11105
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
docker-compose.ymlagainst two security gaps: hardcoded Postgres/Redis credentials and an unboundedapicontainer memory limit. Updates.env.exampleand docs to match.Changes
docker-compose.yml— Postgres credentials replaced with${POSTGRES_USER:-inference},${POSTGRES_PASSWORD:?...}(required, fails fast if unset),${POSTGRES_DB:-inference_engine}docker-compose.yml— Redis starts with--requirepass "${REDIS_PASSWORD:-}"(empty = no auth); healthcheck updated accordinglydocker-compose.yml—apiservice gainsdeploy.resources.limits.memory: ${API_MEMORY_LIMIT:-4g};workerandapiDATABASE_URL/REDIS_URLnow use variable substitution instead of hardcoded literals.env.example— documentsPOSTGRES_USER,POSTGRES_PASSWORD,POSTGRES_DB,REDIS_PASSWORD,API_MEMORY_LIMITwith "CHANGE IN PRODUCTION" warningsdocs/integrations/docker-compose.md— updated environment variables section; added dedicated sections for Postgres credentials, Redis password, and API memory limit; added two troubleshooting rowsType
Testing
pytestpassesdocker compose up, all 4 phases ofbash scripts/curl_test.shpassedRelated Issues
Closes #40