[Bug]: AC0032 - false positive

[guidorobben]

Analyzer

ApplicationCop

Issue type

False positive (diagnostic fires when it shouldn't)

Rule ID

AC0032

Description

The rule reports that the table is not used, but as you can see in the code below, this is not true

AL code to reproduce

 Access = Internal;
    Permissions = 
        tabledata "Purch. Cr. Memo Hdr." = Rm;

    [EventSubscriber(ObjectType::Page, Page::"Pstd. Purch. Cr.Memo - Update", OnAfterRecordChanged, '', false, false)]
    local procedure OnAfterRecordChanged(var PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; xPurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; var IsChanged: Boolean; xPurchCrMemoHdrGlobal: Record "Purch. Cr. Memo Hdr.")
    begin
        IsChanged := IsChanged or
            (PurchCrMemoHdr."Purchaser Code" <> xPurchCrMemoHdrGlobal."Purchaser Code") or
            (PurchCrMemoHdr."Approver WBLC" <> xPurchCrMemoHdrGlobal."Approver WBLC") or
            (PurchCrMemoHdr."On Hold" <> xPurchCrMemoHdrGlobal."On Hold");
    end;

    [EventSubscriber(ObjectType::Codeunit, Codeunit::"Purch. Cr. Memo. Hdr. - Edit", OnBeforePurchCrMemoHdrModify, '', false, false)]
    local procedure OnBeforePurchCrMemoHdrModify(var PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; PurchCrMemoHdrRec: Record "Purch. Cr. Memo Hdr.")
    begin
        if PurchCrMemoHdrRec."Status WBLC" = PurchCrMemoHdrRec."Status WBLC"::Released then
            exit;

        if PurchCrMemoHdrRec."Status WBLC" = PurchCrMemoHdrRec."Status WBLC"::"Pending Approval" then begin
            PurchCrMemoHdrRec.CancelApprovalRequestWBLC();
            PurchCrMemoHdr."Status WBLC" := PurchCrMemoHdr."Status WBLC"::Open;
        end;

        PurchCrMemoHdr.UpdateVendorLedgerEntriesWBLC(PurchCrMemoHdr, PurchCrMemoHdrRec);
        PurchCrMemoHdr."Purchaser Code" := PurchCrMemoHdrRec."Purchaser Code";
        PurchCrMemoHdr."Approver WBLC" := PurchCrMemoHdrRec."Approver WBLC";
        PurchCrMemoHdr."On Hold" := PurchCrMemoHdrRec."On Hold";
    end;

Additional context

No response

[guidorobben]

v0.8.0 beta3

[guidorobben]

[guidorobben]

I also get a warning for every permission so twice instead of 1

[Arthurvdv]

First of thank you for using the beta's releases and providing feedback :-)

The reason the AC0032 raises a diagnostic is that there's no read/insert/modify/delete database operation in the code example you've provided here. I see now the ..no code in this object.. is confusing, so let me update the message that is displayed.

Do you have, by any chance, a small code sample, that shows the message twice? I don't have an repo on this.

[guidorobben]

You can use the code provided to see the the double error. I will provide a sample for the false positive

[guidorobben]

I also know why this is line is added. If you run the the permissions quickfix from AZ Dev Tools, you get this line.

[guidorobben]

This is the false positive

As you can see, there is a Get on the Job table, but also a permission error.

But when I create the sample this is happening

No error anymore. So it looks like a caching issue or something.

[guidorobben]

another example of false positive

[guidorobben]

Another example of false positive

[Arthurvdv]

I'm struggling to get a repo on this, while I see in your printscreen more than obviously that these are false positives, I can't repo this on any of my projects. I've also try'ed the BaseApp, but still can't find an repo on this to investigate what is causing this.

[guidorobben]

Let me see if I can create a repo I can send you.

[guidorobben]

You can download it from this location
https://github.com/guidorobben/BluaceWorkflowEditor

[Arthurvdv]

Thanks, I've downloaded the example and let's see if I can find the culprit...