fix(megatron): patch validate_args and add ROCM argument validation#581
Merged
WangLingxun merged 1 commit intomainfrom Mar 6, 2026
Merged
fix(megatron): patch validate_args and add ROCM argument validation#581WangLingxun merged 1 commit intomainfrom
WangLingxun merged 1 commit intomainfrom
Conversation
WangLingxun
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
WangLingxun
force-pushed
the
fix/megatron-validate-args-rocm
branch
from
9b6d7b4 to
a384b53
Compare
Hook Megatron validate_args alongside parse_args so Primus-injected arguments are validated consistently, and run additional ROCM-specific argument checks during initialization.
WangLingxun
force-pushed
the
fix/megatron-validate-args-rocm
branch
from
a384b53 to
77c1501
Compare
Xiaoming-AMD
approved these changes
Mar 6, 2026
zhaoh27
pushed a commit
that referenced
this pull request
Mar 6, 2026
…581) Hook Megatron validate_args alongside parse_args so Primus-injected arguments are validated consistently, and run additional ROCM-specific argument checks during initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hook Megatron validate_args alongside parse_args so Primus-injected arguments are validated consistently, and run additional ROCM-specific argument checks during initialization.