fix pp dump patch#629
Merged
Xiaoming-AMD merged 2 commits intodev/tas/moe_package_v2.0from Mar 26, 2026
Merged
Conversation
added 2 commits
March 25, 2026 18:36
- Add before_train patch to wrap get_forward_backward_func with schedule_wrapper - Primus pipeline / ZeroBubble: only wrap schedule; handlers already use fwd_bwd_wrapper - Megatron native: wrap schedule and patch forward_step/backward_step via set_dump_pp_data_patch - Add guarded schedule_wrapper to avoid double-wrap in legacy MegatronTrainer flow - Add after_train patch to call dump_pp_data for core runtime
… set_dump_pp_data - Introduce _make_guarded_set_dump_pp_data_patch to ensure set_dump_pp_data_patch is only applied once, addressing legacy MegatronTrainer calls. - Update patch_pp_dump_data_before_train to utilize the new guarded version, enhancing stability in the training pipeline.
lhzhang333
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
Xiaoming-AMD
approved these changes
Mar 26, 2026
lhzhang333
added a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: HuangWei-95 <weihuan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.