fix: file an issue when the milestone isn't found #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the repo doesn't contain the milestone, we still need to create the issue. This prevents losing the results of the test run. It also may handle the case where the repo is forked and the milestone is missing from the fork. This means that we make a best-effort attempt to attach a milestone to the issue. But if we cannot find one, we file the issue with no milestone linkage.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the milestone handling logic when filing GitHub issues to prevent test run results from being lost when a milestone doesn't exist in the repository. Instead of failing with an error when a milestone isn't found, the code now files the issue without a milestone attachment.
Key Changes:
- Removed the
milestone()helper function that would error when a milestone wasn't found - Changed milestone assignment to use
and_then()for optional milestone lookup, allowing issues to be created even when the milestone is missing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
amd-aliem
approved these changes
Oct 15, 2025
Contributor
amd-aliem
left a comment
amd-aliem
left a comment
There was a problem hiding this comment.
Tested and I see the issue created even if I give a bogus milestone now: amd-aliem/sev-certify#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the repo doesn't contain the milestone, we still need to create the issue. This prevents losing the results of the test run. It also may handle the case where the repo is forked and the milestone is missing from the fork.
This means that we make a best-effort attempt to attach a milestone to the issue. But if we cannot find one, we file the issue with no milestone linkage.