Fixed some log vulnerabilities.#39
Merged
Merged
Conversation
Some of the logs could leak sensitive data. Now the logs contains URIs only in DEBUG build, the string changes in Release build.
XDarinor
added
critical
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this.Logger?.LogDebug("Executing GET REST request to {uri}", uri); | ||
| #if DEBUG | ||
| if (this.Logger?.IsEnabled(LogLevel.Debug) == true) | ||
| this.Logger?.LogDebug("Executing GET REST request to {uri}", uri); |
Contributor
Author
There was a problem hiding this comment.
Fixed uri exposure
| this.Logger?.LogDebug("GET REST request to {uri} executed in {elapsed} ms", uri, stopwatch.ElapsedMilliseconds); | ||
| #if DEBUG | ||
| if (this.Logger?.IsEnabled(LogLevel.Debug) == true) | ||
| this.Logger?.LogDebug("GET REST request to {uri} executed in {elapsed} ms", uri, stopwatch.ElapsedMilliseconds); |
Contributor
Author
There was a problem hiding this comment.
Fixed uri exposure
Removed completely the uri logging, just in case. Better logging filtering using the IsEnabled function.
XDarinor
commented
May 19, 2026
Contributor
Author
XDarinor
left a comment
XDarinor
left a comment
There was a problem hiding this comment.
Fixed uri exposure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the logs could leak sensitive data. Now the logs contains URIs only in DEBUG build, the string changes in Release build.
closes #38