#398 improve backend request handling for charts #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elkrival
force-pushed
the
343-update-chart-forms-to-use-the-form-library
branch
2 times, most recently
from
d60ecdd to
fd88d2e
Compare
Base automatically changed from
343-update-chart-forms-to-use-the-form-library
to
pnl-devel
September 20, 2023 19:27
Elkrival
force-pushed
the
396-improve-backend-request-handling-for-charts
branch
from
024ac86 to
844f48c
Compare
* Get all charts * Delete charts * Added destroy verbs on controllers Update Charts Pages to use forms library * Updated the new charts page, edit chart, view charts page to use the react hook form library * Had to update UI to use controlled inputs for react hook forms * Updated initial values to use our hooks * Updated CSV downloader * Added api routes and api verbs for each type of call Charts Controller * Updated the charts controller and routes * Moved additional routes to controller * Added tests Clean Up * Cleaned up code * Added styling to sidebar
Elkrival
force-pushed
the
396-improve-backend-request-handling-for-charts
branch
from
503e25c to
a4f3115
Compare
3 tasks
Elkrival
deleted the
396-improve-backend-request-handling-for-charts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds tests and splits up the logic in the charts routes file into different controllers.
The chartsController was moved to a file called chartsDataController similar as the name on the route and the charts controller has the methods that belong to just charts.