This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Publish branch status over MQTT #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This object will also track the current status of each repo.
Docker is doing evil things with the permissions when it COPYs.
These will not actually be removed from deployed ACS installations under the current system, of course. There are additional permissions required but those are ACS-specific and must be granted in the Helm chart.
Otherwise Node throws an automatic exception and the MQTT library can't retry the connection. This seems to leave the process in some sort of limbo where the exception stops JS running but doesn't actually exit the process.
I thought the MQTT library handled it and queued the packets for later delivery, but apparently not, or maybe this just doesn't apply when we haven't connected at all yet. We only care about publishing the current state, so just skip updates when we're offline; we'll birth when we go online in any case.
The sparkplug-app library is causing an unhandled rejection, which for some reason is not causing Node to exit but to hang. Catch the attempt to handle and force process exit with SIGTERM. (We have to expect to get SIGTERM from time to time anyway under k8s.)
This has cleaned up the start-stops API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish our current branch list and the revision of each branch over MQTT.