This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Fixes for auto-pull #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amrc-benmorrow
commented
Mar 6, 2024
amrc-benmorrow
commented
- Overwrite old git remotes left behind when the process exits halfway through an update.
- Make sure we notify over MQTT on auto-pull.
An ES class inheriting from a non-constructor is not quite clean, but it's cleaner than keeping messing with the prototypes directly.
If the git server is killed while in the middle of doing an update it will leave remotes behind in the git repo.
Apparently the git hook doesn't fire for direct operations on the repo. Or maybe it's just that isomorphic-git doesn't fire hooks at all. I'm not sure pushing to a Subject is the 'best' thing to do, but rewiring everything as a pull leads to side-effects being hidden in sequences.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.