remove some divides in chabrier screening and skip exp if screening fac is negative#1925
Merged
zingale merged 12 commits intoAMReX-Astro:developmentfrom Jan 19, 2026
Merged
Conversation
zingale
reviewed
Jan 19, 2026
screening/screen.H
Outdated
Member
There was a problem hiding this comment.
we might want to also add a min of 0, so the screening factor is never below 1, and then we can skip the exp() in those cases, just like we do with screen5
zhichen3
changed the title
…ophysics into remove_divide_in_screening
zingale
approved these changes
Jan 19, 2026
…ophysics into remove_divide_in_screening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.