Improve BackwardEuler#1987
Draft
BenWibking wants to merge 1 commit intoAMReX-Astro:developmentfrom
Draft
Conversation
- Add time_start parameter to single_step() for explicit time control - Skip clean_state when using number densities (avoid double normalization) - Replace fine/coarse step error estimation with forward/backward Euler comparison (avoids extra Jacobian/RHS evaluations) - Add VODE-like adaptive timestep controller for accept/reject - Fix step counting (was incrementing by 2 per step) - Add verbose step logging for debugging - Add negative species check for use_number_densities mode - Fix initial_timestep: pass do_clean_state and clamp dt not h - Update inputs_vode_example for BackwardEuler compatibility
Member
|
I think part of the initial timestep fix was done in #1976 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack 1 of 2: