-
Notifications
You must be signed in to change notification settings - Fork 433
Use SingleStreamRegion and NoSyncRegion in MLMG solve #4355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SingleStreamRegion and NoSyncRegion in MLMG solve #4355
Conversation
Src/LinearSolvers/MLMG/AMReX_MLMG.H
Outdated
| { | ||
| BL_PROFILE("MLMG::solve()"); | ||
|
|
||
| [[maybe_unused]] Gpu::SingleStreamRegion single_stream_reg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should make this a runtime option. For example, maybe we can add a member function MLMG::setNoGpuSync to control whether we want to avoid gpu sync if possible (and use single stream for safety).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm NoSyncRegion is a bit difficult to use with a runtime parameter
|
@AlexanderSinn thanks for pushing this through! So do you have a call somewhere where you do: |
|
Amr-wind does not build MLMG directly. But, there is a function in amr-wind that gives you a reference to an mlmg object. You can call it at any time before |
Summary
Additional background
Checklist
The proposed changes: