Skip to content

Conversation

@AlexanderSinn
Copy link
Member

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

{
BL_PROFILE("MLMG::solve()");

[[maybe_unused]] Gpu::SingleStreamRegion single_stream_reg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make this a runtime option. For example, maybe we can add a member function MLMG::setNoGpuSync to control whether we want to avoid gpu sync if possible (and use single stream for safety).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm NoSyncRegion is a bit difficult to use with a runtime parameter

@WeiqunZhang WeiqunZhang merged commit 7626a3f into AMReX-Codes:development Mar 28, 2025
75 checks passed
@marchdf
Copy link
Contributor

marchdf commented Mar 28, 2025

@AlexanderSinn thanks for pushing this through! So do you have a call somewhere where you do: setNoGpuSync(true)? In your code? Can you point me to that?

@WeiqunZhang
Copy link
Member

Amr-wind does not build MLMG directly. But, there is a function in amr-wind that gives you a reference to an mlmg object. You can call it at any time before solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants