Skip to content

Fixed Bugs#18

Merged
Martinski4GitHub merged 1 commit intoAMTM-OSR:developfrom
Martinski4GitHub:develop
Jul 23, 2025
Merged

Fixed Bugs#18
Martinski4GitHub merged 1 commit intoAMTM-OSR:developfrom
Martinski4GitHub:develop

Conversation

@Martinski4GitHub
Copy link
Member

@Martinski4GitHub Martinski4GitHub commented Jul 23, 2025

  • Fixed 'read' command when processing WAN events.
  • Fixed variables used for parsing WAN event parameters.

- Fixed 'read' command when processing WAN events.
- Fixed variables used for parsing WAN event parameters.
@Martinski4GitHub Martinski4GitHub requested a review from a team as a code owner July 23, 2025 19:26
@Martinski4GitHub
Copy link
Member Author

@ExtremeFiretop,
Out of curiosity and just for fun while having my lunch (WFH today), I pulled the Ethernet cable from the WAN port of the RT-AC86U and later plugged it back in to see if the WAN uptime was reset & adjusted correctly. Well, I got the "No WAN events detected" message. After debugging, I found 2 bugs in the code that handles the WAN events passed from the 'wan-event' script. These bugs are now fixed in this PR.

@Martinski4GitHub Martinski4GitHub merged commit fb32dcf into AMTM-OSR:develop Jul 23, 2025
2 checks passed
@ExtremeFiretop
Copy link
Member

Just in time as I'm about to start testing! Nice catch! Not sure when or how I changed the variable names...

@ExtremeFiretop
Copy link
Member

I happened to just bump into a bug in MerlinAU. Will discuss more with you on that side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants