Skip to content

Conversation

peterbrightwell
Copy link
Contributor

As per Steering/BoD decision today

@peterbrightwell peterbrightwell requested a review from a team September 20, 2022 16:33
@peterbrightwell
Copy link
Contributor Author

peterbrightwell commented Sep 20, 2022

Perhaps spec.yml should include show_in_index: false so it doesn't appear on https://github.com/AMWA-TV/nmos and in the menus?

@pedro-alves-ferreira
Copy link

Perhaps spec.yml should include show_in_index: false so it doesn't appear on https://github.com/AMWA-TV/nmos and in the menus?

What if it was there but clearly marked as deprecated? Would it be difficult to add another flag to render it differently? Otherwise, how would one find it?

@peterbrightwell
Copy link
Contributor Author

Probably best to leave it in the index (could be in a separate section for deprecated specs?) but we could omit it from the IS menu.

Could have a tickbox to show Deprecated specifications (and one for WIP specs?)

In any case that shouldn't affect approval of this PR

Copy link

@pedro-alves-ferreira pedro-alves-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbrightwell peterbrightwell merged commit f7555fc into v1.0.x Sep 21, 2022
@peterbrightwell peterbrightwell deleted the deprecate branch September 21, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants