-
Notifications
You must be signed in to change notification settings - Fork 59
A minor fix and an addition for the Energy Reconstruction toolchains #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the storing location of ScalingVarsStore.bs since the Data_Energy_Reco directory doesn't exist in the main ToolAnalysis repository.
Applied the cuts that we use currently in the Energy Reconstruction.
Lowered the verbosity
Upped the verbosity
Upped the verbosity
Lowered the verbosity
Adding a config file for the PhaseIITreeMaker Tool so we can use it in the Energy Reconstruction ToolChain.
Removed the .txt from the file name
Added a line for the PhaseIITreeMaker Tool
Changed the path of ScalingVarsStore.bs according to the change I made in the Train_Test/DNNTrackLengthTrainConfig
Applied the current cuts used in the Energy Reconstruction
Lowered the verbosity
Upped the verbosity
Upped the verbosity
Added a line for the PhaseIITreeMaker Tool
Adding a config file for PhaseIITreeMaker just like I did for the Train_Test ToolChain
Removed the .txt from the file name
Added a histogram that plots the Energy Relative Deviation between E_true and E_reco
Added a missing line
Added lines of code to the .h and .cpp files to include the digitX, digitY, digitZ and digitT variables in the root ouput
re-trigger workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some minor changes in the existing config files of the EnergyReco Training and Predicting ToolChains. Most importantly, I changed the storing location of the ScalingVarsStore.bs file in the DNNTrackLengthTrainConfig, because the current path leads to a directory that doesn't exist in the main ToolAnalysis repository. This causes the file to not be stored at all and makes the training unusable.
I added a new histogram in the PlotsTrackLengthAndEnergy Tool that plots the (Etrue-Ereco)/Etrue distribution.
I added the PhaseIITreeMaker Tool in the EnergyReconstruction ToolChains.
I added some lines of code in the PhaseIITreeMaker.cpp and PhaseIITreeMaker.h files so that the .root output contains info on the digitX, digitY, digitZ and digitT variables.