Added LAPPDWaveformDisplay tool #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkandemirr
changed the title
S81D
reviewed
Aug 28, 2025
configfiles/LAPPDana/ConfigGeo
Outdated
| DetectorGeoFile ./configfiles/LoadGeometry/DetectorGeometrySpecs.csv | ||
| LAPPDGeoFile ./configfiles/LAPPDana/LAPPDGeometry.csv | ||
| TankPMTGeoFile ./configfiles/LoadGeometry/FullTankPMTGeometry.csv | ||
| TankPMTGainFile ./configfiles/LoadGeometry/ChannelSPEGains_BeamRun20192020.csv |
Collaborator
There was a problem hiding this comment.
Please update this to the latest geometry file:
it has been updated to the latest geometry file.
S81D
reviewed
Sep 3, 2025
| mIsEventRangeDefined = true; | ||
| } | ||
|
|
||
| std::string storeErrMsg = "Error: Data retrieval from 'Store' failed."; |
Collaborator
There was a problem hiding this comment.
Not a big deal but in the future it will be easier for someone to de-bug if you add independent output for which data object failed to be retrieved from the store.
Collaborator
|
I think everything looks good. All instances of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This tool visualizes LAPPD waveforms for each event and generates a PDF file. The necessary explanations and configuration details for this tool can be found in the Readme file.
This tool has been tested within the ToolAnalysis framework, as part of the LAPPDana toolchain, and the output file is included in the attachment.
In ToolAnalysis, there is another tool called LAPPDPlotWaveForms2D, which, contrary to what its name suggests, does not create plots. Instead, it generates a ROOT file and saves histograms in it. After taking laser data in Fermilab’s Lab 6 darkroom, the LAPPDPlotWaveForms2D tool is used within the LAPPDana toolchain to create this ROOT file, which is then visualized using an independent Python code. The new tool, LAPPDWaveformDisplay, simplifies this process by generating the visualizations in one step.
Additionally, this tool is more general and includes extra features, which are detailed in the Readme file.
LAPPDWaveformDisplay.pdf
Checklist before submitting your PR
newusage, there is a reason the data must be on the heapnewthere is adelete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
Attach any validation or demonstration files here. You may also link to relavant docdb articles.