Lab6's tools: timistamp, waveform's max, min and rms branches FIXED #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CalcMinMaxAmp method to LAPPDTraceMax class.
Added a new function to calculate minimum and maximum amplitudes along with RMS, standard deviation, variance, and integral of the waveform.
Added new variables for noise study and metadata timestamps also adding RMS, min and max waveform amplitudes fro dark room data
Removed unnecessary closing brace and adjusted formatting.
marc1uk
reviewed
Nov 12, 2025
|
|
||
| //std::cout<<"-------------TIMESTAMP In tree ---------------------------------"<<std::endl; | ||
| int meta_timestamp_int; | ||
| std::string meta_timestamp = acdcmetadata[204] + acdcmetadata[206] + acdcmetadata[208] + acdcmetadata[210]; |
Collaborator
There was a problem hiding this comment.
use at method or check vector size.
Can we have some explanation for magic numbers 204, 206, 208, 210? or define enums instead?
Contributor
Author
There was a problem hiding this comment.
I added more comments about the numbers and also I al using at
Added error handling for ACDCmetadata retrieval and refactored timestamp extraction from ACDC metadata.
Refactor CalcMinMaxAmp function to correct min/max assignments and removing double mean calculation.
Collaborator
|
Thanks Marvin 👍 |
Contributor
Author
|
Thank you for checking. I added in hurry those branches to have more sense of the lab6 data. We are still using them and I PR without cleaning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Tools:
LAPPDClusterTree
LAPPDTraceMax
Waveform amplitude max, min, rms variables added in LAPPDTraceMax.
Branches related to the variables able plus the timestamps added in LAPPDClusterTree
OBS:
Those tools are important for the LAPPD testing at Lab6.