Skip to content

chore: fix Renovate preset reference#100

Merged
github-actions[bot] merged 2 commits into
mainfrom
chore/renovate-preset-fix
May 18, 2026
Merged

chore: fix Renovate preset reference#100
github-actions[bot] merged 2 commits into
mainfrom
chore/renovate-preset-fix

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented May 18, 2026

Switch extends from O-ANcppLua/renovate-config (which 404s) to canonical ANcpLua/renovate-config. Auto-merge will land this once required checks pass.

@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@github-actions github-actions Bot enabled auto-merge (squash) May 18, 2026 00:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Behavior Changed

Renovate configuration will now resolve its base preset from the correct repository. The extends field was updated from github>O-ANcppLua/renovate-config (a typo-laden reference returning 404) to github>ANcpLua/renovate-config. The self-bump blockage for ANcpLua.Agents packages via packageRules remains semantically unchanged.

Risk Surface

  • External dependency: Renovate behavior now depends on the stability and correctness of the external ANcpLua/renovate-config preset. Configuration drift or breaking changes in that preset will directly impact this repository's dependency update behavior.
  • Configuration resolution failure: If ANcpLua/renovate-config is removed or becomes inaccessible, Renovate will fail to apply configuration and may fall back to defaults or error.

Validation Evidence

  • Original reference contained a character transposition ("O-ANcppLua" vs. "ANcpLua"), indicating a transcription error rather than intentional pointing to an alternate source.
  • No alternate configurations or conditional logic in the file; the change is straightforward pointer correction.
  • packageRules configuration for dependency handling is preserved without modification.

Cross-Repository Implications

This repository now explicitly depends on the external preset at ANcpLua/renovate-config. Changes to that preset—including removal of rules, modifications to update schedules, or dependency group definitions—will propagate to all consuming repositories, including this one.

Walkthrough

Updated renovate.json to extend the shared Renovate configuration from a renamed repository (github>ANcpLua/renovate-config instead of github>O-ANcppLua/renovate-config), while preserving the existing packageRules that disable self-bumps for ANcpLua.Agents.

Changes

Renovate Configuration Base Update

Layer / File(s) Summary
Renovate Configuration Base Update
renovate.json
Changed the extends field to reference github>ANcpLua/renovate-config instead of github>O-ANcppLua/renovate-config, preserving the existing packageRules configuration for suppressing self-bumps of ANcpLua.Agents.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ANcpLua/renovate-config#27: Directly related—the same renovate preset reorganization work, repointing the base config source to the renamed repository.
  • ANcpLua/ANcpLua.NET.Sdk#163: Parallel repository configuration update that performs the same renovate preset repoint across a different project.

Suggested labels

area:build, area:infra

🚥 Pre-merge checks | ✅ 18 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
No Null-Forgiving Operator Without Justification ⚠️ Warning 31 null-forgiving operators (!) added in new C# files with zero inline comment justifications. Examples: return content!, options.Endpoint!, (TOutput)e.Data!, Path.GetDirectoryName(project.FullPath)! Add inline comments (// reason) before/after each ! null-forgiving operator to justify why null-safety suppression is necessary at that location.
No Preview-Type Leak Into Stable Surface ⚠️ Warning Stable public APIs in src/ANcpLua.Agents expose Microsoft.Extensions.AI preview types without [Experimental] attributes on the consuming types. Mark public types/methods using MAF preview APIs with [Experimental] or [RequiresPreviewFeatures] attributes.
✅ Passed checks (18 passed)
Check name Status Explanation
Title check ✅ Passed Title follows conventional commit format with 'chore' type and descriptive scope, is well under 72 characters, and accurately names the highest-impact change: fixing the broken Renovate configuration reference.
Description check ✅ Passed Description directly addresses the changeset by explaining the specific configuration error (404 URL) and the correction applied, with clear context about auto-merge behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Secrets Or Pii ✅ Passed PR adds no secrets, tokens, API keys, or PII. All credential references use GitHub secrets syntax. Test placeholders are obviously synthetic. No hardcoded sensitive data found.
Generated Files Regenerated ✅ Passed renovate.json is a direct configuration file, not a generated artifact. The PR fixes a config reference; no source schema/generator input change triggers downstream file regeneration requirements.
Async And Cancellation Safe ✅ Passed PR modifies only renovate.json configuration. No C#/TS/Python code changes present. Custom check's async/cancellation safety criteria do not apply to configuration-only PRs.
Public Contract Documented ✅ Passed renovate.json is internal CI/CD config, not published with packages. No public APIs, schemas, or contracts changed—not subject to this check.
Ci Release Safety ✅ Passed No workflow, build, or release files were changed. The PR modifies only renovate.json (Renovate automation config), which falls outside the scope of CI Release Safety checks.
Tests Match Risk ✅ Passed Configuration-only fix to Renovate preset reference. No production code changes, no runtime behavior impact, no areas requiring integration/e2e testing touched. Not applicable to check.
No Copy Paste Tables ✅ Passed No copy-paste tables or redundant hardcoded structures introduced. PR only fixes a configuration URL reference in renovate.json. The existing packageRules structure is minimal and non-duplicative.
No Hidden Fallback Path ✅ Passed PR fixes broken preset reference (404 O-ANcppLua to canonical ANcpLua). No fallback, wrapper, or error-masking behavior. Declarative config only.
Observability Boundary ✅ Passed PR only modifies renovate.json configuration. No new services, background jobs, queues, network clients, storage writers, MCP tools, or agent workflows are introduced. Custom check not applicable.
Dependency Hygiene ✅ Passed Config-only change. Centralized package management with documented security pins. No lockfile drift. All conventions met.
No Datetime.Now/Utcnow ✅ Passed No C# files added or modified in this PR. The custom check explicitly requires scanning C# files for DateTime usage; since no C# files are changed, the check passes.
No .Result/.Wait() Blocking Async ✅ Passed No C# files were added or modified in this PR. The change only updates renovate.json, a JSON configuration file. The check for blocking async patterns does not apply.
Suppressions Limited To Meai001/Openai002 ✅ Passed No C# files are added or modified in this PR. Only renovate.json is changed. Suppressions check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/renovate-preset-fix
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/renovate-preset-fix
  • 🛠️ architecture hardening
  • 🛠️ security pass
  • 🛠️ test gap closure
  • 🛠️ docs and changelog alignment
  • 🛠️ performance and allocation pass

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 17 linked repositories, but your current plan allows 10. Analyzed ANcpLua/ANcpLua.Analyzers, ANcpLua/ANcpLua.NET.Sdk, O-ANcppLua/ANcpLua.OtelConventions.Api, ANcpLua/ANcpLua.Roslyn.Utilities, ANcpLua/Arqio, ANcpLua/BSc_2025_Alexander_Nachtmann, ANcpLua/C64AIToolChain, ANcpLua/ErrorOrX, O-ANcppLua/Nuke.OpenTelemetry.Conventions, ANcpLua/Paperless, skipped ANcpLua/ancplua-claude-plugins, ANcpLua/dotcov, ANcpLua/nhmw-digital-collection, O-ANcppLua/qyl, ANcpLua/safe-autoresearch, ANcpLua/typespec-otel-semconv, ANcpLua/yt-transcript.


Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown

claude Bot commented May 18, 2026

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 18, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR successfully updates the Renovate configuration in renovate.json to point to the correct repository path for its preset, replacing the invalid reference. The code is up to standards according to Codacy analysis, and the implementation fully satisfies the intended requirement.

Test suggestions

  • Validate that renovate.json extends from the correct GitHub repository

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

coderabbitai[bot]
coderabbitai Bot previously requested changes May 18, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@renovate.json`:
- Line 3: The renovate.json extends property was changed to
"github>ANcpLua/renovate-config" but other repos and docs still reference the
old preset; update the extend string in the other repositories
(ANcpLua.Analyzers, ANcpLua.NET.Sdk, ANcpLua.Roslyn.Utilities) to match the new
preset ("github>ANcpLua/renovate-config") and also update any documentation and
workflow comments (e.g., AGENTS.md and workflow files) that reference
"github>O-ANcppLua/renovate-config" so all references are consistent and won’t
404; coordinate the commits/PRs across those repos so the change rolls out
simultaneously.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0ba70d7f-5821-4fca-bc76-9383c048a8b4

📥 Commits

Reviewing files that changed from the base of the PR and between e091835 and d341423.

📒 Files selected for processing (1)
  • renovate.json
📜 Review details
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: build (windows-latest)
  • GitHub Check: build (macos-latest)
  • GitHub Check: Codacy Static Code Analysis
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{cs,ts,tsx,js,jsx,json,yaml,yml,props,csproj}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Skip files whose first ~3 lines contain // Ported from <upstream>, // Generated, or // Auto-generated — surface a one-line note instead of line-level findings

Files:

  • renovate.json
🔀 Multi-repo context ANcpLua/ANcpLua.Analyzers, ANcpLua/ANcpLua.NET.Sdk, O-ANcppLua/ANcpLua.OtelConventions.Api, ANcpLua/ANcpLua.Roslyn.Utilities, ANcpLua/Arqio, ANcpLua/ErrorOrX, O-ANcppLua/Nuke.OpenTelemetry.Conventions, ANcpLua/Paperless

ANcpLua/ANcpLua.Analyzers

  • renovate.json — extends "github>O-ANcppLua/renovate-config" [::ANcpLua/ANcpLua.Analyzers::renovate.json:3]
  • AGENTS.md — documentation link referencing O-ANcppLua/renovate-config [::ANcpLua/ANcpLua.Analyzers::AGENTS.md:10]
  • .github/workflows/auto-merge.yml — comment referencing the O-ANcppLua preset [::ANcpLua/ANcpLua.Analyzers::.github/workflows/auto-merge.yml:6]

ANcpLua/ANcpLua.NET.Sdk

  • renovate.json — extends "github>O-ANcppLua/renovate-config" [::ANcpLua/ANcpLua.NET.Sdk::renovate.json:3]
  • AGENTS.md — documentation link referencing O-ANcppLua/renovate-config [::ANcpLua/ANcpLua.NET.Sdk::AGENTS.md:9]
  • .github/workflows/auto-merge.yml — comment referencing the O-ANcppLua preset [::ANcpLua/ANcpLua.NET.Sdk::.github/workflows/auto-merge.yml:6]

O-ANcppLua/ANcpLua.OtelConventions.Api

  • renovate.json — already extends "github>ANcpLua/renovate-config" (no change needed) [::O-ANcppLua/ANcpLua.OtelConventions.Api::renovate.json:3]

ANcpLua/ANcpLua.Roslyn.Utilities

  • renovate.json — extends "github>O-ANcppLua/renovate-config" [::ANcpLua/ANcpLua.Roslyn.Utilities::renovate.json:3]
  • AGENTS.md — documentation link referencing O-ANcppLua/renovate-config [::ANcpLua/ANcpLua.Roslyn.Utilities::AGENTS.md:9]
  • .github/workflows/auto-merge.yml — comment referencing the O-ANcppLua preset [::ANcpLua/ANcpLua.Roslyn.Utilities::.github/workflows/auto-merge.yml:6]

ANcpLua/Arqio

  • src/Arqio.DependencyTools/renovate.json — uses "local>ANcpLua/renovate-config" (local preset reference) [::ANcpLua/Arqio::src/Arqio.DependencyTools/renovate.json:4]
  • CHANGELOG.md — mentions ANcpLua/renovate-config PRs in history (contextual) [::ANcpLua/Arqio::CHANGELOG.md:10,24]

ANcpLua/ErrorOrX

  • renovate.json — uses "local>ANcpLua/renovate-config" [::ANcpLua/ErrorOrX::renovate.json:4]

O-ANcppLua/Nuke.OpenTelemetry.Conventions

  • renovate.json — extends "github>ANcpLua/renovate-config" (already pointing to ANcpLua) [::O-ANcppLua/Nuke.OpenTelemetry.Conventions::renovate.json:3]

ANcpLua/Paperless

  • renovate.json — uses "local>ANcpLua/renovate-config" [::ANcpLua/Paperless::renovate.json:4]

Summary / impact

  • Multiple ANcpLua/* repos (ANalyzers, NET.Sdk, Roslyn.Utilities) currently reference the old "github>O-ANcppLua/renovate-config" and will benefit from the same repoint-to-ANcpLua change to avoid 404s. Some repos already point to ANcpLua/renovate-config or use local>ANcpLua/renovate-config and do not need this fix.
🔇 Additional comments (1)
renovate.json (1)

3-3: ⚡ Quick win

Preset reference is valid and comprehensive.

The new preset github>ANcpLua/renovate-config exists, is publicly accessible, and contains well-designed configuration explicitly for ANcpLua repos (including ANcpLua.Agents). The preset includes 37 packageRules covering NuGet stability policies, Microsoft Agent Framework maturity tracking (stable/RC/preview/alpha quarantine), first-party package automerge, and extensive Version.props custom managers. Fixes the old broken 404 reference.

Comment thread renovate.json
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>O-ANcppLua/renovate-config"],
"extends": ["github>ANcpLua/renovate-config"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Cross-repository consistency: other repos still reference the old preset.

Linked repositories ANcpLua.Analyzers, ANcpLua.NET.Sdk, and ANcpLua.Roslyn.Utilities still extend github>O-ANcppLua/renovate-config and will continue to 404 until updated. Documentation files (AGENTS.md) and workflow comments also reference the old preset. Consider coordinating updates across the ecosystem to prevent configuration drift.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@renovate.json` at line 3, The renovate.json extends property was changed to
"github>ANcpLua/renovate-config" but other repos and docs still reference the
old preset; update the extend string in the other repositories
(ANcpLua.Analyzers, ANcpLua.NET.Sdk, ANcpLua.Roslyn.Utilities) to match the new
preset ("github>ANcpLua/renovate-config") and also update any documentation and
workflow comments (e.g., AGENTS.md and workflow files) that reference
"github>O-ANcppLua/renovate-config" so all references are consistent and won’t
404; coordinate the commits/PRs across those repos so the change rolls out
simultaneously.

@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@claude
Copy link
Copy Markdown

claude Bot commented May 18, 2026

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

⛔ CodeRabbit does not have permission to push changes to this repository. Please ensure CodeRabbit has Contents: Read and write permission.

@ANcpLua ANcpLua dismissed coderabbitai[bot]’s stale review May 18, 2026 00:57

Resolved: the cross-repo cleanup CodeRabbit flagged has been completed in parallel — Analyzers#162, Roslyn.Utilities#128, claude-plugins#250 all merged; 7 other repos direct-pushed via API. This PR completes the set.

@github-actions github-actions Bot merged commit 0dcc410 into main May 18, 2026
11 checks passed
@ANcpLua ANcpLua deleted the chore/renovate-preset-fix branch May 18, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant